[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v7 23/28] build: convert HAS_EHCI use to Kconfig

>>> On 10.12.15 at 17:48, <cardoe@xxxxxxxxxx> wrote:
> +# USB EHCI debug port support
> +config HAS_EHCI
> +     bool
> +     depends on X86

As said before, dependencies on prompt-less options are bogus
and potentially confusing (and really wrong here - there's nothing
precluding ARM to also use that code as soon as they gain PCI
support). With you adding a forward and reverse dependency I'm
surprised you don't actually get a warning from kconfig.

If anything, a dependency on PCI might be considered here
(albeit I'd suggest against it for aforementioned reason).


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.