[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 5/9] xenstore: modify init-xenstore-domain parameter syntax

On 15/12/15 07:22, Ian Campbell wrote:
On Fri, 2015-12-11 at 16:47 +0100, Juergen Gross wrote:
init-xenstore-domain takes only positional parameters today. Change
this to a more flexible parameter syntax allowing to specify additional
options or to omit some.

Today the supported usage is:

init-xenstore-domain <xenstore-kernel> <memory_mb> <flask-label>

Modify this to:

init-xenstore-domain --kernel <xenstore-kernel>
                      --memory <memory_mb>
                      [--flask <flask-label>]
                      [--ramdisk <ramdisk-file>]

The flask label is made optional in order to support xenstore domains
without the need of a flask enabled hypervisor.

Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

Looks fine to me

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

I'd like to see Daniel opinion of all the changes to init-xenstore-domain.c
in this series though.

This and the other command line changes in #7 look good, and make the
rather opaque invocation of the tool a bit nicer to read.

Acked-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.