[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 4/9] xenstore: add error messages to init-xenstore-domain

On 15/12/15 07:20, Ian Campbell wrote:
Adding Daniel again.

On Fri, 2015-12-11 at 16:47 +0100, Juergen Gross wrote:
Additional add some diagnostic messages to the program to have an idea
why it failed.
        if (dom)
+       if (domid >= 0)
+               xc_domain_destroy(xch, domid);

This important looking bug fix should't be buried in this otherwise quite
mechanical commit.

The rest looks reasonable, so with the above moved to a separate commit
this one would be:
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>


Both parts of the fix look good, split or together (but I agree that
splitting is better for the history).  Either way:

Acked-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.