Re: [Xen-devel] [PATCH v2 03/13] libxl: provide a function to retrieve the xenstore domain id

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2015-12-18 at 15:10 +0100, Juergen Gross wrote:
> On 18/12/15 14:53, Andrew Cooper wrote:
> > On 18/12/15 13:14, Juergen Gross wrote:
> > > Add libxl_xenstore_domid() to obtain the domain id of the xenstore
> > > domain.
> > > 
> > > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> > 
> > What are the expected semantics here? Would you expect it to return
> > domid 0 for a traditional setup, or are you wanting to use it as a
> > "does
> > a xenstored domain exist" test?
> 
> The latter. It will be used in patch 13 to decide which domain to
> stop via "xl shutdown --all".

ITYM "not stop".

libxl already has interfaces for getting info about a
domain,Âlibxl_domain_infoÂlibxl_list_domain etc, it seems like this
property should be added to that data rather than introducing a special
purpose API to get it. Especially given that xl shutdown already calls
libxl_list_domain.

I'm unsure if (lib)xl ought to be special casing XS in this way, as opposed
to adding a more generic concept such as e.g. permanent domains, which
would be true for the xs domain but also for other special domains in the
future and could even be controlled by the user or toolstack (I'm thinking
you might want to set the flag on a driver domain for example).

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel