Re: [Xen-devel] [PATCH 1/2] vm_event: sync domctl

[Tamas K Lengyel <tamas@xxxxxxxxxxxxx>]

On Wed, Jan 6, 2016 at 4:48 PM, Ian Campbell <ian.campbell@xxxxxxxxxx> wrote:

On Wed, 2015-12-23 at 15:53 +0100, Tamas K Lengyel wrote:
> Introduce new vm_event domctl option which allows an event subscriber
> to request all vCPUs not currently pending a vm_event request to be
> paused,
> thus allowing the subscriber to sync up on the state of the domain. This
> is especially useful when the subscribed wants to disable certain events
> from being delivered and wants to ensure no more requests are pending on
> the
> ring before doing so.
>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> Cc: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
> Signed-off-by: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
> ---
> Âtools/libxc/include/xenctrl.h | 11 +++++++++++
> Âtools/libxc/xc_vm_event.cÂÂÂÂÂ| 16 ++++++++++++++++

Tools side is pretty trivial, assuming there is agreement on the underlying
hypercall interface:

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Thanks, we've decided that this patch is actually not needed as the pause reference count is already good enough.

Â

> +/***
> Â * Memory sharing operations.

Do you also maintain this? If so do you fancy sending a patch to fix:

> Â *
> Â * Unles otherwise noted, these calls return 0 on succes, -1 and errno on

"Unless" and "success" ?

Sure, that could be done in a separate patch. IMHO the whole sharing subsystem could use a cleanup series of its own to fix things like this, style issues and whatnot.

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel