Re: [Xen-devel] [PATCH OSSTEST] make-flight: Support specifying a mini-os tree+revision

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH OSSTEST] make-flight: Support specifying a 
mini-os tree+revision"):
> On Fri, 2015-12-11 at 15:16 +0000, Ian Jackson wrote:
>     unable to determine vcs
>     bash: line 5: fail: command not found
> 
> I'm not sure if this is a bug (i.e. it was intended to be "echo fail") or
> if it is deliberately using  a non-existent command (which seems risky to
> me).

It's deliberately using the command `fail' which is supposed to be in
scope and fail.  I think this is harmless.

> All the other store_revisions refer to the symlink rather than the -remote
> which is the actual clone (when one is made), so I don't think
> s#extras/mini-os#extras/mini-os-remote# is the answer. Perhaps "fail"
> should become "echo fail" and store_revision should treat that like it does
> fail (which is to accept it if $optional).

That would be tolerable, I think.  It's probably the best answer.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel