Re: [Xen-devel] [PATCH] x86: shrink 'struct domain', was already PAGE_SIZE

[Corneliu ZUZU <czuzu@xxxxxxxxxxxxxxx>]

On 2/1/2016 1:07 PM, Andrew Cooper wrote:
> On 01/02/16 07:42, Corneliu ZUZU wrote:
> > The X86 domain structure already occupied PAGE_SIZE (4096).
> >
> > Looking @ the memory layout of the structure, we could see that
> > overall most was occupied by (used the pahole tool on domain.o):
> >   * sizeof(domain.arch) = sizeof(arch_domain) = 3328 bytes.
> >   * sizeof(domain.arch.hvm_domain) = 2224 bytes.
> >   * sizeof(domain.arch.hvm_domain.pl_time) = 1088 bytes.
> > This patch attempts to free some space, by making the pl_time
> > field in hvm_domain dynamically allocated.
> > We xzalloc/xfree it @ hvm_domain_initialise/hvm_domain_destroy.
> >
> > After this change, the domain structure shrunk w/ 1152 bytes (>1K!).
> >
> > Signed-off-by: Corneliu ZUZU <czuzu@xxxxxxxxxxxxxxx>
> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>
> Thankyou for doing this - it is exactly the kind of change I had in mind.
>
> ~Andrew
Glad to hear that and thank you for the prompt review :) I really needed 
this for another patch.
Corneliu.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel