Re: [Xen-devel] [PATCH] x86/PV: fix unintended dependency of m2p-strict mode on migration-v2

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 01.02.16 at 15:07, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 01/02/16 13:20, Jan Beulich wrote:
>> Ping? (I'd really like to get this resolved, so we don't need to
>> indefinitely run with non-upstream behavior in our distros.)
> 
> My remaining issue is whether this loop gets executed by default.
> 
> I realise that there is a difference between legacy and v2 migration,
> and that v2 migration by default worked.  If that means we managed to
> skip this loop in its entirety for v2, then I am far less concerned
> about the overhead.

But had been there before: Of course we could skip the loop if
the bit in d->vm_assist doesn't change. But as expressed before,
with you having already indicated that perhaps it would be better
to have v2 migration do the relevant operations in the other (v1)
order, the moment that was actually done the benefit of avoiding
the loop would be gone.

To be clear - if rendering the code dead (which is what you ask
for) until v2 migration happens to get changed is the only way to
get this code in, I will submit a v2 with that extra conditional.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel