Re: [Xen-devel] [PATCH 2/3] Add a weekly coverity flight

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[PATCH 2/3] Add a weekly coverity flight"):
> In my experiments the curl command took ~35 minutes to complete (rate
> in the 100-200k range). Not sure if this is a problem. Note that curl
> is run on the controller (via system_checked) and consequently has no
> timeout etc.

Can you use curl's builtin timeouts, or wrap it in alarm() ?
Otherwise I think it is possible for this to become wedged
indefinitely and need manual un-wedging.

AFAICT during the curl the only lock or resource which is held is the
build host share.  I think we can live with that.

> Note that the token must be supplied with </path/to/token and not
> @/path/to/token. The latter appears to the server as a file upload
> rather than a text field in a form which doesn't work. In early
> attempts I thought that the trailing \n in /path/to/token might be an
> issue and hence wrote a big comment. However having discovered < vs @
> I am no longer 100% sure that is the case, but I left the comment
> anyway since I can observe on the wire that the \n is included in the
> upload (but each test takes ~35 mins and there is a ratelimit on the
> server side too).

Right.

> Deployment notes:
>  - Put cov-analysis-linux64-7.7.0.4.tar.gz in the Images
>    directory. DONE in COLO
>  - Populate $HOME/.xen-osstest/coverity-secret with the token
>    DONE in COLO
>  - Populate xen.git#coverity-scanned with an initial baseline, update
>    ap-fetch-version-old to refer to it instead of master.
...
> +coverity)
> +     #XXX doesn't exist yet, use master for now repo_tree_rev_fetch_git xen 
> $TREE_XEN coverity-scanned $LOCALREV_XEN

This XXX is out of date ?  And so the code should be fixed ?


> +     case $branch in
> +         coverity)
> +             if [ "x$TREE_COVERITY" = x ]; then
> +                 export TREE_COVERITY=$TREE_XEN
> +             fi
> +             if [ "x$REVISION_COVERITY" = x ]; then
> +                 determine_version REVISION_COVERITY coverity COVERITY
> +                 export REVISION_COVERITY
> +             fi
> +             NEW_REVISION=$REVISION_COVERITY

I'm not sure why these variables are all REVISION_COVERITY rather than
REVISION_XEN.

But in general this looks good.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel