Re: [Xen-devel] [PATCH V9 5/5] x86/hvm: pkeys, add pkeys support for cpuid handling

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Feb 03, 2016 at 10:12:05PM +0800, Huaitong Han wrote:
> This patch adds pkeys support for cpuid handing.
> 
> Pkeys hardware support is CPUID.7.0.ECX[3]:PKU. software support is
> CPUID.7.0.ECX[4]:OSPKE and it reflects the support setting of CR4.PKE.
> 
> X86_FEATURE_OSXSAVE depends on guest X86_FEATURE_XSAVE, but cpu_has_xsave
> function reflects hypervisor X86_FEATURE_XSAVE, it is fixed too.
> 
> Signed-off-by: Huaitong Han <huaitong.han@xxxxxxxxx>

As far as I can tell changes to libxc are in line with overall coding
style and convention in that file.  I'm happy to give my ack on this
patch if hypervisor maintainers are happy about the changes.

There is one nit below.
[...]
> -            /* Don't expose PCOMMIT to hvm when VMX support is not available 
> */
> +            /* Don't expose PCOMMIT to hvm when VMX support is not 
> available. */

White space only change. This should not be included here.

>              if ( !cpu_has_vmx_pcommit )
>                  *ebx &= ~cpufeat_mask(X86_FEATURE_PCOMMIT);
>          }
> -- 
> 2.4.3
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel