Re: [Xen-devel] [PATCH v7 11/18] tools/libxl: Add back channel to allow migration target send data back

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Jan 29, 2016 at 01:27:27PM +0800, Wen Congyang wrote:
> In COLO mode, secondary needs to send the following data to primary:
> 1. In libxl
>    Secondary sends the following CHECKPOINT_CONTEXT to primary:
>    CHECKPOINT_SVM_SUSPENDED, CHECKPOINT_SVM_READY and CHECKPOINT_SVM_RESUMED
> 2. In libxc
>    Secondary sends the dirty pfn list to primary
> 
> But the io_fd only can be written in primary, and only can be read in
> secondary. Save recv_fd in domain_suspend_state, and send_fd in
> domain_create_state. Extend libxl_domain_create_restore API, add a
> send_fd param to it. Add LIBXL_HAVE_CREATE_RESTORE_SEND_FD to indicate
> the API change.
> 
> Signed-off-by: Wen Congyang <wency@xxxxxxxxxxxxxx>
> Signed-off-by: Yang Hongyang <hongyang.yang@xxxxxxxxxxxx>
> ---
>  tools/libxl/libxl.c                  |  2 +-
>  tools/libxl/libxl.h                  | 30 ++++++++++++++++++++++++++++--
>  tools/libxl/libxl_create.c           |  9 +++++----
>  tools/libxl/libxl_internal.h         |  2 ++
>  tools/libxl/xl_cmdimpl.c             |  8 +++++++-
>  tools/ocaml/libs/xl/xenlight_stubs.c |  2 +-
>  6 files changed, 44 insertions(+), 9 deletions(-)
> 
> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> index fc7844d..e286329 100644
> --- a/tools/libxl/libxl.c
> +++ b/tools/libxl/libxl.c
> @@ -871,7 +871,7 @@ int libxl_domain_remus_start(libxl_ctx *ctx, 
> libxl_domain_remus_info *info,

The TODO before this function can also be deleted now.

This patch is mostly about stashing the recv_fd. Assuming that is going
to be used later:

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel