Re: [Xen-devel] [PATCH v2 07/13] xsplice: Add helper elf routines (v2)

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

> >+#define return_(x) { printk(XENLOG_DEBUG "%s:%d rc: %d\n",  \
> >+                            __func__,__LINE__, x); return x; }
> >+

.. snip..
> >+        printk(XENLOG_ERR "Could not allocate memory for section table!\n");
> 
> Shouldn't this printk be removed if you're using return_?

I was torn on the return_ macro. At one hand it helps to identify what
went wrong with the payload file. But at the same time it is very
developer-centric - so perhaps not to be in the final piece.

And yes, if we do want to go ahead with the return_ macro, then this
should go away.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel