Re: [Xen-devel] [PATCH] xen: sched: get rid of static private schedulers' structures

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.02.16 at 14:19, <dario.faggioli@xxxxxxxxxx> wrote:
> @@ -1995,13 +1996,11 @@ static void csched_tick_resume(const struct scheduler 
> *ops, unsigned int cpu)
>              - now % MICROSECS(prv->tick_period_us) );
>  }
>  
> -static struct csched_private _csched_priv;
> -
>  static const struct scheduler sched_credit_def = {
>      .name           = "SMP Credit Scheduler",
>      .opt_name       = "credit",
>      .sched_id       = XEN_SCHEDULER_CREDIT,
> -    .sched_data     = &_csched_priv,
> +    .sched_data     = NULL,

You're maintainer of this code, so you know whether you really
want these NULL initializers, but the look pretty pointless to me.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel