[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 2/7] x86: hvm events: merge 2 functions into 1
- To: Jan Beulich <JBeulich@xxxxxxxx>
- From: Corneliu ZUZU <czuzu@xxxxxxxxxxxxxxx>
- Date: Tue, 9 Feb 2016 13:52:49 +0200
- Cc: Kevin Tian <kevin.tian@xxxxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, Keir Fraser <keir@xxxxxxx>, Ian Campbell <ian.campbell@xxxxxxxxxx>, Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxx, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>
- Comment: DomainKeys? See http://domainkeys.sourceforge.net/
- Delivery-date: Tue, 09 Feb 2016 11:52:57 +0000
- Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=bitdefender.com; b=evvXDE6vFqmAF5BhgVJcxkI3oYVETsRvvapV8nLnul6h77zCC2miwGZvxJTA6vTqYfgl4j3NVwYwWxGFK+J+Uutr9XjZsXw6+G4bHmlvcTL09nZXIgKtak8amxlCPdyEqp9ZVBWF/FgBDGJVdnM/rWVBpP5yvFy37sBqj7FZ9WU+vc33XLzimICpFsFIIU23o9FvHSkc8hgfnC4rlkGju/fFbyezFHK/4HJ0NzPWDnd1JRLt5d45693qyxf7z0zxwBuSmp6SJF6HR8xYrZkZ3qTx1NjVYdhh4c3YGrR9F/V81UicpsAMztJhWJGcfjYdL+V9g19kg5h9fMJewVwsnQ==; h=Received:Received:Received:Received:Received:Subject:To:References:Cc:From:Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding:X-BitDefender-Scanner:X-BitDefender-Spam:X-BitDefender-SpamStamp:X-BitDefender-CF-Stamp;
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On 2/9/2016 1:19 PM, Jan Beulich wrote:
On 08.02.16 at 17:57, <czuzu@xxxxxxxxxxxxxxx> wrote:
This patch merges almost identical functions hvm_event_int3
and hvm_event_single_step into a single function called
hvm_event_software_breakpoint.
Except that "software breakpoint" is rather questionable a name
here, considering that on x86 this is basically an alias for "int3".
If it was "breakpoint", one might argue (see the other responses
you've got) that breakpoint event resulting from debug register
settings might then be candidates to come here too.
Jan
Yeah..should I then:
* keep both functions and only rename hvm_event_int3 to
hvm_event_software_breakpoint
* separate the code that gets the GFN of the instruction pointer in a
static inline function
?
Corneliu.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
