Re: [Xen-devel] [PATCH v3 3/3] altp2m: Implement p2m_get_mem_access for altp2m views

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.02.16 at 22:22, <tlengyel@xxxxxxxxxxx> wrote:
> --- a/xen/include/public/memory.h
> +++ b/xen/include/public/memory.h
> @@ -423,11 +423,20 @@ struct xen_mem_access_op {
>      /* xenmem_access_t */
>      uint8_t access;
>      domid_t domid;
> -    /*
> -     * Number of pages for set op
> -     * Ignored on setting default access and other ops
> -     */
> -    uint32_t nr;
> +    union {
> +        /*
> +         * Number of pages for set op
> +         * Ignored on setting default access and other ops
> +         */
> +        uint32_t nr;
> +        /*
> +         * altp2m id used for get op, ignored for other ops
> +         */
> +        struct altp2m {
> +            uint16_t idx;
> +            uint16_t pad;
> +        } altp2m;
> +    } u;

Am I overlooking something, or is this new padding field not being
checked to be zero on input (allowing seamless use for an actual
purpose later on)? It's a tools-only interface (i.e. not considered
stable), but anyway...

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel