Re: [Xen-devel] [PATCH v4 1/2] libxl: add p2p migration

[Jim Fehlig <jfehlig@xxxxxxxx>]

On 02/05/2016 01:45 PM, Joao Martins wrote:
> Introduce support for VIR_MIGRATE_PEER2PEER in libvirt migration.
> Most of the changes occur at the source and no modifications at
> the receiver.
>
> In P2P mode there is only the Perform phase so we must handle the
> connection with the destination and actually perform the
> migration. libxlDomainPerformP2P implements the connection to the
> destination and libxlDoMigrateP2P implements the actual migration
> logic with virConnectPtr. In this function we take care of doing
> all phases of migration in the destination similar to
> virDomainMigrateVersion3Full. We appropriately save the last
> error reported in each of the phases to provide proper reporting.
> We don't yet support VIR_MIGRATE_TUNNELED and we always use V3
> with extensible params, thus it also makes the implementation
> simpler.
>
> It is worth noting that the receiver didn't have any changes, and
> since it's still the v3 sequence thus it is possible to migrate
> from a P2P to non-P2P host.
>
> Signed-off-by: Joao Martins <joao.m.martins@xxxxxxxxxx>
> ---
> Note: v4 series requires the patch 
> ("remote: set VIR_TYPED_PARAM_STRING_OKAY on migration") [0]
> to make migration work again, but it's not reviewed yet.
> [https://www.redhat.com/archives/libvir-list/2016-February/msg00317.html]
>
> Changes since v3:
>  - Put keep alive support into a separate patch and do it with
>  proper configuration.
>  - Fixed spelling errors on commit message.
>
> Changes since v2:
>  - Remove Connect Close callback
>
> Changes since v1:
>  - Move Begin step to libxlDoMigrateP2P to have all 4 steps
>   together.
>  - Remove if before VIR_FREE(dom_xml)
> ---
>  src/libxl/libxl_driver.c    |  13 ++-
>  src/libxl/libxl_migration.c | 197 
> ++++++++++++++++++++++++++++++++++++++++++++
>  src/libxl/libxl_migration.h |  11 +++
>  3 files changed, 218 insertions(+), 3 deletions(-)

ACK.

Regards,
Jim



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel