Re: [Xen-devel] [PATCH v2 24/30] tools/libxc: Modify bitmap operations to take void pointers

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 08/02/16 16:36, Ian Campbell wrote:
> On Mon, 2016-02-08 at 16:23 +0000, Tim Deegan wrote:
>> At 13:42 +0000 on 05 Feb (1454679737), Andrew Cooper wrote:
>>> The type of the pointer to a bitmap is not interesting; it does not
>>> affect the
>>> representation of the block of bits being pointed to.
>> It does affect the alignment, though.  Is this safe on ARM?
> Good point. These constructs in the patch:
>
> +    const unsigned long *addr = _addr;
>
> Would be broken if _addr were not suitably aligned for an unsigned long.
>
> That probably rules out this approach unfortunately.

What about reworking libxc bitops in terms of unsigned char?  That
should cover all alignment issues.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel