[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v2 4/7] Rename monitor_x86.c to monitor.c and monitor_arch.h to monitor.h
- To: Jan Beulich <JBeulich@xxxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
- From: Corneliu ZUZU <czuzu@xxxxxxxxxxxxxxx>
- Date: Wed, 10 Feb 2016 22:54:56 +0200
- Cc: Keir Fraser <keir@xxxxxxx>, Ian Campbell <ian.campbell@xxxxxxxxxx>, Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
- Comment: DomainKeys? See http://domainkeys.sourceforge.net/
- Delivery-date: Wed, 10 Feb 2016 20:55:07 +0000
- Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=bitdefender.com; b=qfjEkh4Fu6gNKEVrnLXx1Qog0K/aNh6AzuLIcMVhgT7uR2pVaEtvKyGO0WiC4NYH+zFW2q2URIGTMK66t3CP8ij0I5lfo4S9RlWnnSk+rdcdwxWnDkTk+MwaY1XvEp9dPv/u4Ii5gwJcgJhq85DOIgGmnstBkay+PP1ra3XFDVxZDdLpZnz3v3/yAnIAFBmgx5nhT4bMfm7P7Io3WcVURV4/yE3PJbmHh/7IwO5nU4gRXLQDkPoHcQY6Y7+SSZL4lrSAHib0lBbvzPVYYYLKfQHpeGsOrCmqElTPGifVPiqhsBtsCk66rr9ZbbszbWjgB7KveS/KQztx6WQf2jBA1A==; h=Received:Received:Received:Received:Received:Subject:To:References:Cc:From:Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding:X-BitDefender-Scanner:X-BitDefender-Spam:X-BitDefender-SpamStamp:X-BitDefender-CF-Stamp;
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On 2/10/2016 7:16 PM, Jan Beulich wrote:
On 10.02.16 at 17:44, <tamas@xxxxxxxxxxxxx> wrote:
On Wed, Feb 10, 2016 at 8:54 AM, Corneliu ZUZU <czuzu@xxxxxxxxxxxxxxx>
wrote:
Rename:
- arch/x86/monitor_x86.c -> arch/x86/monitor.c
- asm-{x86,arm}/monitor_arch.h -> asm-{x86,arm}/monitor.h
(previous commit explains why these renames were necessary)
Referencing a "previous commit" like this is not acceptable as you don't
know how these patches will get applied and there might be other patches
that get committed in-between yours. In each patch explain clearly why the
patch is needed. I still find it odd that you need to rename x86/monitor.c
-> x86/monitor_x86.c -> x86/monitor.c in the same series.
Indeed. Thinking about it again perhaps the operations should be
"move to common/ (mostly) verbatim" followed by "break out x86
specific code" (if that's the smaller portion compared to what is to
stay).
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
That's a great alternative! Will do so in v3.
Corneliu.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
