Re: [Xen-devel] [PATCH 1/3] xen/x86: Drop the uses of invbool_param()

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2016-02-09 at 05:46 -0700, Jan Beulich wrote:
> > > > On 08.02.16 at 18:07, <andrew.cooper3@xxxxxxxxxx> wrote:
> > There are only four users, and invbool_param() is an unnecessary
> > cognitive
> > overhead to use.
> 
> While this isn't necessarily a bad change, I don't agree to either of
> these arguments. So I'm going to make my ack here dependent on
> seeing some kind of positive feedback on patch 2 by another
> REST maintainer.

FWIW I do have to think a little harder about the double negative in
        bool_t foo; /* implicitly 0 Âinit */
        invbool_param("foo", foo_disabled);
and what no-foo on the command line actually does in this case than I would
otherwise with:
        bool_t foo = true;
        boolean_param("foo", foo);

AFAICT the only real benefit of the inversion is that the variable can live
in .bss instead of .data, but it's a total of 4 bool_t's (so 4 bytes? Or
maybe 16 at the most) which hardly seems worth it to me.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel