Re: [Xen-devel] [PATCH 3/3] xen: credit1: avoid boosting vCPUs being "just" migrated

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Thu, 2016-02-11 at 06:30 -0700, Jan Beulich wrote:
> > > > On 11.02.16 at 12:39, <dario.faggioli@xxxxxxxxxx> wrote:
> > --- a/xen/common/sched_credit.c
> > +++ b/xen/common/sched_credit.c
> > @@ -1022,11 +1022,14 @@ csched_vcpu_wake(const struct scheduler
> > *ops, struct vcpu *vc, unsigned wf)
> > ÂÂÂÂÂÂ* more CPU resource intensive VCPUs without impacting
> > overallÂ
> > ÂÂÂÂÂÂ* system fairness.
> > ÂÂÂÂÂÂ*
> > -ÂÂÂÂÂ* The one exception is for VCPUs of capped domains unpausing
> > -ÂÂÂÂÂ* after earning credits they had overspent. We don't boost
> > -ÂÂÂÂÂ* those.
> > +ÂÂÂÂÂ* There are a couple of exceptions, when we don't want to
> > boost:
> > +ÂÂÂÂÂ*ÂÂ- VCPUs that are waking up after a migration, rather than
> > +ÂÂÂÂÂ*ÂÂÂÂafter having block;
> > +ÂÂÂÂÂ*ÂÂ- VCPUs of capped domains unpausing after earning credits
> > +ÂÂÂÂÂ*ÂÂÂÂthey had overspent.
> > ÂÂÂÂÂÂ*/
> > -ÂÂÂÂif ( svc->pri == CSCHED_PRI_TS_UNDER &&
> > +ÂÂÂÂif ( !(wf & WF_migrated) &&
> > +ÂÂÂÂÂÂÂÂÂsvc->pri == CSCHED_PRI_TS_UNDER &&
> > ÂÂÂÂÂÂÂÂÂÂ!test_bit(CSCHED_FLAG_VCPU_PARKED, &svc->flags) )
> > ÂÂÂÂÂ{
> 
> Considering the other svc->flags check done here, wouldn't it be
> possible to achieve the same effect without patch 2, by having
> csched_cpu_pick() set a newly defined flag, and check for it here?
> 
It can indeed. I've coded it up, and I like the way it came out better.

I'm rerunning the benchmarks right now (just in case! :-)). I'll send
v2 out as soon as they finish.

I did like the idea of "wakeup flags", and I think they may actually
turn out useful, but they're not necessary for this specific use case,
as it appears. Well, next time. ;-)

Thanks and Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel