Re: [Xen-devel] [PATCH v2 4/6] xen: add capability to load initrd outside of initial mapping

[Daniel Kiper <daniel.kiper@xxxxxxxxxx>]

Hey Juergen,

On Fri, Feb 12, 2016 at 07:25:02AM +0100, Juergen Gross wrote:

[...]

> Okay, let me do some cleanup work on the xen loader:
>
> - add the possibility to call it multiple times (state reset, free the
>   allocated memory)
> - merge all necessary global variables into one state structure, use
>   local variables where possible
> - introduce lots of constants instead of using numerical values all over
>   the code

Make sense for me.

> The first two items should go in before my series. The third is more a
> question of style, so it might block the complete series if I put it
> early in the series and such a change isn't regarded to be positive.
> Would you be okay if I put the constant introduction at the end of the
> series? This would result in readable code (at least I hope so) in case

OK, let's do that in that way.

> it is accepted and wouldn't block the functionality in case it is
> rejected. In case there is an early okay from the maintainer(s), I can
> do the constant introduction early, too, of course.

Granted!

Daniel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel