[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] vm_event: Remove xc_mem_access_enable_emulate() and friends



>>> On 12.02.16 at 10:04, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
> --- a/xen/include/public/memory.h
> +++ b/xen/include/public/memory.h
> @@ -390,8 +390,6 @@ DEFINE_XEN_GUEST_HANDLE(xen_mem_paging_op_t);
>  #define XENMEM_access_op                    21
>  #define XENMEM_access_op_set_access         0
>  #define XENMEM_access_op_get_access         1
> -#define XENMEM_access_op_enable_emulate     2
> -#define XENMEM_access_op_disable_emulate    3

Considering that the interface isn't versioned, I think you should
just comment those out instead of entirely removing them, to
make obvious for the next one to add an operation here that
these two values may not be re-used.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.