[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] x86/HVM: fold hypercall tables
>>> On 15.02.16 at 09:26, <andrew.cooper3@xxxxxxxxxx> wrote: > On 15/02/2016 07:42, Jan Beulich wrote: >> @@ -5395,7 +5398,7 @@ int hvm_do_hypercall(struct cpu_user_reg >> } >> #endif >> >> - regs->_eax = hvm_hypercall32_table[eax](ebx, ecx, edx, esi, edi, >> ebp); >> + regs->_eax = hypercall_table[eax].compat(ebx, ecx, edx, esi, edi, > ebp); >> > > I know its in a different translation unit, but we already have a > hypercall_table and it is a global symbol. Please could we retain the > hvm_ prefix here. I'm aware of that and removed the prefix knowingly. I see no reason why it needs to be there. With static symbols now getting prefixed by their file names in stack dumps and alike, I think we should actually get rid of any such redundant static symbol name prefixes (scheduler code being one of the biggest "user" of such). > Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Please clarify whether the R-b stands nevertheless, or whether we need to have a longer debate first. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |