[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] git workflow and http://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches


I wanted to ask what folks would think of expanding the Wiki to include (making 
it a diff
for simpler) this change. With my giant 30 set of patches that not only CC-ed
xen-devel twice but had some patches CC some maintainers but not others - I 
it may be good to describe this in the Wiki:

--- orig        2016-02-15 10:45:27.719204371 -0500
+++ new 2016-02-15 10:58:33.113755665 -0500
@@ -140,7 +140,35 @@
 * The maintainers are listed in the MAINTAINERS file at the top of the Xen 
source tree. If no maintainer is listed then there is no need for a CC (if you 
are modifying code with no maintainer then you might like to consider becoming 
the maintainer for that piece of code!).
 ** You can pipe your patch to the <code>./scripts/get_maintainer.pl</code> 
tool and it will list the relevant maintainers.
 * In addition to CCing the maintainer you should always send patches to (via 
TO) the xen-devel@xxxxxxxxxxxxxxxxxxxx mailing list as well.
-* To add a CC when sending the mail you can use the ''--cc'' option to the 
''git send-email'' command, or you can do it manually in your MUA.
+* To add a CC when sending the mail you can:
+  * use the ''--cc'' option to the ''git send-email'' command - however if your
+    patchset is to multiple maintainers - you may end up sending all of the
+    patches to all maintainers  - where some of them have no interest in
+    viewing them (as they are not under their responsibility).
+  * edit each patch to have the proper maintainer on the CC list by adding:
+CC: joe@xxxxxxx
+   in the patch.
+  * or alternatively use --cc-cmd in your .gitconfig:
+    cc-cmd = scripts/get_maintainer.pl --remove-duplicates --no-l
+which will automatically add the proper maintainer on the CC line.
+The ''no-l'' is to not add the mailing list to the CC (as you would
+be adding that via the TO - see above)
+  * or you can do it manually in your MUA.
+In short, it could look like this:
+git send-email --to xen-devel@xxxxxxxxxxxxxxxxxxxx --to jo@xxxxxxx --compose 
--subject "[PATCH v1] Fixes to frobnicator." *.patch
+Which will send all patches to yourself on the TO, to xen-devel mailiing list 
(on the TO:)
+and the patches will have their CC: list generated based on 
 === Providing a git branch ===

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.