Xen project Mailing List

Re: [Xen-devel] [PATCH v3 1/2] xen/x86: merge 2 hvm_event_... functions into 1

To: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>

From: Corneliu ZUZU <czuzu@xxxxxxxxxxxxxxx>

Date: Mon, 15 Feb 2016 19:54:23 +0200

Cc: Kevin Tian <kevin.tian@xxxxxxxxx>, Keir Fraser <keir@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>

Comment: DomainKeys? See http://domainkeys.sourceforge.net/

Delivery-date: Mon, 15 Feb 2016 17:54:36 +0000

Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=bitdefender.com; b=P1ot3d3zeL/eYHbWFkKOx7hfLsScHefAf+rcUqwwyuuVmmfpkHqO5HVX+MrpRVzDBDebECh45Inrssq9cmA6ePQWo/RHJCVTGT/0XnTO/obP3wsNvabfWPoAS7BDRW1hBeqFomjCFjJmK6+yCuVbxgzdXgB5MqTs26zLU29h4VIbRUXTvFZZ1MqN61hLhi4Xnfj3DvPE6cKQWRRlsop46ew3RRcbfSvCjK1+scJZEPjJj94Mt6WMO89wfuKuv9hCDLq5XLvYT1MWESIT/oN6i3YqmVD7+L+2kO7y2x2WM+T/3Q4KCMejaynqvH/OB5JaAk2Uvm35LHCcJyCVsoO9AQ==; h=Received:Received:Received:Received:Received:Subject:To:References:Cc:From:Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:Content-Type:X-BitDefender-Scanner:X-BitDefender-Spam:X-BitDefender-SpamStamp:X-BitDefender-CF-Stamp;

List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 2/15/2016 7:47 PM, Tamas K Lengyel wrote:

On Mon, Feb 15, 2016 at 10:40 AM, Corneliu ZUZU <czuzu@xxxxxxxxxxxxxxx> wrote:

On 2/15/2016 10:30 AM, Razvan Cojocaru wrote:

On 02/15/2016 08:35 AM, Corneliu ZUZU wrote:

This patch merges almost identical functions hvm_event_int3 and
hvm_event_single_step into a single function called hvm_event_breakpoint.
Also fixes event.c file header comment in the process.

Signed-off-by: Corneliu ZUZU <czuzu@xxxxxxxxxxxxxxx>
---
Â xen/arch/x86/hvm/event.cÂ Â Â Â | 108 +++++++++++++++++++---------------------
Â xen/arch/x86/hvm/vmx/vmx.cÂ Â Â |Â 15 +++---
Â xen/include/asm-x86/hvm/event.h |Â 11 ++--
Â 3 files changed, 67 insertions(+), 67 deletions(-)

Looks good to me.

Acked-by: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>

Thanks,
Razvan

If the patch hasn't been merged to staging yet then include it. If it's a longer series the cover page can indicate which patches are still in need of review and which ones have been already acked. Furthermore, for each patch under the Signed-off-by tag you can say what changed in each revision. If nothing changed, you can say no change or just don't put anything for that revision. See http://lists.xen.org/archives/html/xen-devel/2016-02/msg00943.html for an example. Also keep in mind that if the changes in a revision are significant enough you can't keep the Acked-by tag on the patch, it will need to be re-acked.

Tamas

Got it, thanks.

Corneliu.

_______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel