Re: [Xen-devel] [PATCH v3 1/3] PMU: make {acquire, release}_pmu_ownership names consistent

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 02/17/2016 09:37 AM, Doug Goldstein wrote:
> The function names were inconsistent with acquire and release being
> called acquire_pmu_ownership() and release_pmu_ownship() respectively.
> Function prototypes were available for both spellings so this change
> makes them consistent and drops the dual function prototypes.
> Additionally change the internal variable names within those functions
> to ownership as well.
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>

although I think

> diff --git a/xen/common/xenoprof.c b/xen/common/xenoprof.c
> index 19b4605..7a3fc86 100644
> --- a/xen/common/xenoprof.c
> +++ b/xen/common/xenoprof.c
> @@ -50,16 +50,16 @@ static u64 passive_samples;
>   static u64 idle_samples;
>   static u64 others_samples;
>   
> -int acquire_pmu_ownership(int pmu_ownship)
> +int acquire_pmu_ownership(int pmu_ownership)
>   {
>       
using 'new_pmu_owner' as argument might be slightly better.

-boris

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel