Re: [Xen-devel] [PATCH 5/5] x86: drop failsafe callback invocation from assembly

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 17/02/16 16:38, Jan Beulich wrote:
> Afaict this was never necessary on a 64-bit hypervisor, and was instead
> just blindly cloned over from 32-bit code: We don't fiddle with (and
> hence don't reload) any of DS, ES, FS, or GS, and an exception on IRET
> itself can equally well be reported to the guest as that very exception
> on the target of that IRET.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

As best as I can tell, this looks safe.

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

This is one area I intend to write an XTF test for, but I havn't had
time to yet.  I will see if I can dig out the start of the test and
complete it.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel