Re: [Xen-devel] [PATCH v2 04/16] xen: credit2: pack trace data better for xentrace_format

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Thu, 2016-02-18 at 11:10 +0000, George Dunlap wrote:
> On 16/02/16 18:11, Dario Faggioli wrote:
> > when tracing runstate changes, the vcpu and domain IDs
> > are encoded in the lower and higher, respectively, parts
> > of a 32 bits integer. When decoding a trace with
> > xentrace_format, this makes it possible to display
> > such events like this:
> > 
> > CPU0ÂÂ833435853624 (+ÂÂÂÂÂ768)ÂÂrunning_to_runnable [ dom:vcpu =
> > 0x7fff0000 ]
> > CPU0ÂÂ833435854416 (+ÂÂÂÂÂ792)ÂÂrunnable_to_running [ dom:vcpu =
> > 0x00000007 ]
> > 
> > For consistency, we should do the same when displaying
> > the events coming from the Credit2 scheduler (when using
> > the same tool), and to do that, we need to invert the
> > order in which the fields are being put in the trace
> > struct right now.
> > 
> > Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> > Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> 
> I was going to say, "We should change xentrace_format and xenalyze in
> lockstep", but it turns out that they don't support these trace
> records
> yet!ÂÂÂI must have some patches to xenalyze in a local branch
> somewhere
> that I never upstreamed properly.
> 
If I understand what you mean, I'm doing exactly that in the second
half of this series (and per the latest email, the xentrace_format
part, you've seen it already). :-)

> So, all is well:
> 
> Acked-by: George Dunlap <george.dunlap@xxxxxxxxxx>
> 
Thanks,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel