Re: [Xen-devel] [PATCHv1 4/5] x86/viridian: set x87 FIP width to 4 for Windows guests

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 18.02.16 at 19:52, <david.vrabel@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/hvm/viridian.c
> +++ b/xen/arch/x86/hvm/viridian.c
> @@ -148,6 +148,30 @@ static void dump_guest_os_id(const struct domain *d)
>             goi->fields.service_pack, goi->fields.build_number);
>  }
>  
> +static void set_guest_os_id(struct domain *d, uint64_t val)
> +{
> +    const union viridian_guest_os_id *goi;
> +
> +    d->arch.hvm_domain.viridian.guest_os_id.raw = val;
> +    goi = &d->arch.hvm_domain.viridian.guest_os_id;

Please flip the two lines and use goi also for the assignment
of val.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel