[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] arm/monitor vm-events: Implement guest-request support


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
  • From: Corneliu ZUZU <czuzu@xxxxxxxxxxxxxxx>
  • Date: Fri, 19 Feb 2016 18:10:39 +0200
  • Cc: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, Keir Fraser <keir@xxxxxxx>, Ian Campbell <ian.campbell@xxxxxxxxxx>, Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxx, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
  • Comment: DomainKeys? See http://domainkeys.sourceforge.net/
  • Delivery-date: Fri, 19 Feb 2016 16:10:48 +0000
  • Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=bitdefender.com; b=IA2gmVbXEZXE5LJleIOAVW554Pvdf2gT6gjtGeAQp9EU7AXLncjOlKFb3v+R4QFfQiSkvnKr1z5DEHPTwFBFM9+jLHICF+GzfRH6Yw87r6Qq7oe2jquQRMgWBSBEYi9UyXqldb2clg8sklsNYh367+AtMbJY/EB1Rbzksse3P9E1w2DjvmH3JqtaFGrjtl935pjK5zeczMDYxlwBGmvtoV/bsUFmWBx4XhJEqt1rXaka48s0hsJ2xeyefVFEPdM+KSWZnuFJLk0ua0HybllgR4u/GiasnOgpnYthSL1A1cJujeAY8r0fYBaiVFb5Ys+gtvzO3ikZy6J5Pqv3pT5DNQ==; h=Received:Received:Received:Received:Received:Subject:To:References:Cc:From:Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding:X-BitDefender-Scanner:X-BitDefender-Spam:X-BitDefender-SpamStamp:X-BitDefender-CF-Stamp;
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 2/19/2016 6:05 PM, Andrew Cooper wrote:
On 19/02/16 16:00, Stefano Stabellini wrote:
On Fri, 19 Feb 2016, Corneliu ZUZU wrote:
On 2/19/2016 3:49 PM, Stefano Stabellini wrote:
On Thu, 18 Feb 2016, Corneliu ZUZU wrote:
+
+    if ( sync )
+    {
+        req->flags |= VM_EVENT_FLAG_VCPU_PAUSED;
+        vm_event_vcpu_pause(v);
+    }
+
+#if CONFIG_X86
+    if ( altp2m_active(d) )
I would rather

#define altp2m_active(d) (0)

on ARM, removing the two ifdefs in this file.
Yeah, I actually wanted to get rid of that too at some point, the question is,
what do I do with "req->altp2m_idx = vcpu_altp2m(v).p2midx"? I'm not familiar
w/ altp2m design, maybe someone that knows more of the internals of that can
give a suggestion.
If you #define altp2m_active to (0), gcc will automatically avoid the if
statement.
You will still get the compile error from ARM's struct vcpu not having
altp2m information.

~Andrew


Yep.

Corneliu.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.