Re: [Xen-devel] [PATCH v3 1/2] hvm/vmx: save dr7 during vmx_vmcs_save

["Lengyel, Tamas" <tlengyel@xxxxxxxxxxx>]

On Fri, Feb 19, 2016 at 10:26 AM, Lengyel, Tamas <tlengyel@xxxxxxxxxxx> wrote:

On Fri, Feb 19, 2016 at 10:18 AM, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:

On 19/02/16 17:06, Lengyel, Tamas wrote:

On Tue, Feb 16, 2016 at 3:47 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:

>>> On 16.02.16 at 07:58, <kevin.tian@xxxxxxxxx> wrote:
>> --- a/xen/arch/x86/hvm/vmx/vmx.c
>> +++ b/xen/arch/x86/hvm/vmx/vmx.c
>> @@ -490,6 +490,7 @@ static void vmx_vmcs_save(struct vcpu *v, struct hvm_hw_cpu
>> *c)
>>Â Â Â __vmread(GUEST_SYSENTER_CS, &c->sysenter_cs);
>>Â Â Â __vmread(GUEST_SYSENTER_ESP, &c->sysenter_esp);
>>Â Â Â __vmread(GUEST_SYSENTER_EIP, &c->sysenter_eip);
>> +Â Â __vmread(GUEST_DR7, &c->dr7);
>>
>
> Hi, Tamas, I didn't see the open closed around "v != current", if
> I'm not missing some mails... Have you confirmed with Jan that
> he is OK with it?

We didn't really settle on this yet. I'm not heavily opposed to it
remaining unconditional for now, but as said in the other replay
my fear is that this might later lead to further additions which
may then also be of no interest to the main (save/migration)
user of this code.

Andrew, any comment if this is OK from your perspective?

I specifically suggested the use of vmx_save_dr() to make all debug state consistent.

I might have missed that comment.

Â

I don't see much purpose in being able to introspect just %dr7. If any debug related activities are going on, all debug registers are relevant.

Is this not the case?

Right now only dr7 is included in the automatic register snapshot sent with each vm_event. I personally don't use any of them so I can't comment on how it would be useful by itself (Razvan?). From my perspective the only issue at hand has been that the current way dr7 was gathered was incorrect. IMHO if someone needs the other debug registers for each vm_event, that change can be introduced in a separate patch.

In case this needs any more discussion I will split the dr7 fix parts from the consolidation patch as there is no need to have it be held up. It has already been acked and is unrelated to this issue.

Thanks,

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel