Re: [Xen-devel] [PATCH v3 06/23] xsplice: Implement payload loading (v4)

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

> > +         hdr->e_ident[EI_CLASS] != ELFCLASS64 ||
> > +         hdr->e_ident[EI_DATA] != ELFDATA2LSB ||
> > +         hdr->e_ident[EI_OSABI] != ELFOSABI_SYSV ||
> > +         hdr->e_machine != EM_X86_64 ||
> > +         hdr->e_type != ET_REL ||
> > +         hdr->e_phnum != 0 )
> > +    {
> > +        printk(XENLOG_ERR "%s: Invalid ELF file.\n", elf->name);
> 
> Where possible, please avoid punction in error messages.  Its just
> wasted characters on the uart.
> 
> I would also suggest the error message be "xpatch '%s': Invalid ELF
> file\n" to give the observer some clue that we are referring to payload
> attached to a specific xsplice patch.

Isn't elf->name doing that already?
> 
> > +        return -EOPNOTSUPP;
> > +    }
> > +
> > +    return 0;
> > +}
> > +
> > +int xsplice_perform_rel(struct xsplice_elf *elf,
> > +                        struct xsplice_elf_sec *base,
> > +                        struct xsplice_elf_sec *rela)
> > +{
> > +    printk(XENLOG_ERR "%s: SHR_REL relocation unsupported\n", elf->name);
> 
> Simiarly here.  All the error messages should have some common
> indication that we are in the xsplice subsystem.

I changed that one to dprintk so it will have it. Let me add the xSplice
be part of the naming convention in all the printk's that can come about
in the field.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel