[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 1/4] tools/configure: only require bcc/ld86/as86 when needed



On 2/19/16 8:27 AM, Doug Goldstein wrote:
> On 2/19/16 8:00 AM, Konrad Rzeszutek Wilk wrote:
>> On Thu, Feb 18, 2016 at 08:57:02PM -0600, Doug Goldstein wrote:
>>> bcc/ld86/as86 are only necessary when we build rombios and not always so
>>> failing the build when they aren't available should not happen if the
>>> user isn't building rombios.
>>
>> That is quite the long sentence. Perhaps trim it down to:
>>
>> "are necessary when we build ROMBIOS. However if we do not build it 
>> (not building qemu-trad) - the build requirements are overly strict
>> and can lead to failures." ?
>>
>> Otherwise
>> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
>>
> 
> Agreed. That's better. Thank you for the review.
> 
> 

Hoping to get some more reviews before I resend this with the wording
update. 3/4 has no reviews.

-- 
Doug Goldstein

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.