Re: [Xen-devel] [PATCHv2 2/3] x86/fpu: Add a per-domain field to set the width of FIP/FDP

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 23/02/16 11:10, Andrew Cooper wrote:
> On 23/02/16 11:05, David Vrabel wrote:
>> @@ -653,6 +657,12 @@ int arch_domain_create(struct domain *d, unsigned int 
>> domcr_flags,
>>      /* PV/PVH guests get an emulated PIT too for video BIOSes to use. */
>>      pit_init(d, cpu_khz);
>>  
>> +    /*
>> +     * If the FPU not to save FCS/FDS then we can always save/restore
> 
> "If the FPU does not" ?
> 
>> @@ -284,7 +284,11 @@ void xsave(struct vcpu *v, uint64_t mask)
>>              return;
>>          }
>>  
>> -        if ( word_size > 0 &&
>> +        /*
>> +         * If the FIP/FDP[63:32] are both zero, it is safe to use the
>> +         * 32-bit restore to also restore the selectors.
>> +         */
> 
> This comment is presumably applicable to the fxsave path?

Yes.  Do you want this comment added there?

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel