Re: [Xen-devel] [PATCH] version: Document guest_handle

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Mon, Feb 22, 2016 at 05:32:53AM -0700, Jan Beulich wrote:
> >>> On 19.02.16 at 15:32, <konrad@xxxxxxxxxx> wrote:
> > --- a/xen/include/public/version.h
> > +++ b/xen/include/public/version.h
> > @@ -79,6 +79,10 @@ typedef struct xen_feature_info xen_feature_info_t;
> >  #define XENVER_pagesize 7
> >  
> >  /* arg == xen_domain_handle_t. */
> > +/*
> > + * The toolstack fills it out for the guest consumption. Usually it is
> > + * the UUID of the guest but can be anything.
> > + */
> >  #define XENVER_guest_handle 8
> 
> Generally fine, but I'm not overly happy with the wording. I'd
> prefer if it was made slightly less vague this is meant to be the
> UUID. Maybe "The toolstack fills it out for guest consumption. It
> is intended to hold the UUID of the guest"?
> 
> Jan
> 

Attached as well:

From 7da6d169835acb4aa93bfa48b1ae6b8e198f8e5f Mon Sep 17 00:00:00 2001
From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Date: Fri, 19 Feb 2016 09:26:02 -0500
Subject: [PATCH] version: Document guest_handle

And what it is usually used for.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Reviewed-by: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>

---
v2: Reword per Jan's suggestion.
---
 xen/include/public/version.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/xen/include/public/version.h b/xen/include/public/version.h
index adca602..5e6a7ea 100644
--- a/xen/include/public/version.h
+++ b/xen/include/public/version.h
@@ -78,7 +78,11 @@ typedef struct xen_feature_info xen_feature_info_t;
 /* arg == NULL; returns host memory page size. */
 #define XENVER_pagesize 7
 
-/* arg == xen_domain_handle_t. */
+/* arg == xen_domain_handle_t.
+ *
+ * The toolstack fills it out for guest consumption. It is intended to hold
+ * the UUID of the guest.
+ */
 #define XENVER_guest_handle 8
 
 #define XENVER_commandline 9
-- 
2.1.0

Attachment: 0001-version-Document-guest_handle.patch
Description: Text document

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel