[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 03/16] xen: sched: improve domain creation tracing



On Wed, 2016-02-24 at 04:52 -0700, Jan Beulich wrote:
> > > > On 24.02.16 at 12:21, <dario.faggioli@xxxxxxxxxx> wrote:
> > On Thu, 2016-02-18 at 11:04 +0000, George Dunlap wrote:
> > > On 16/02/16 18:11, Dario Faggioli wrote:
> > > > by doing the following two things:
> > > > 
> > > > Â- move TRC_SCHED_DOM_{ADD,REM}, into the functions
> > > > ÂÂÂthat do the actual scheduling-related domain
> > > > ÂÂÂinitialization;
> > > > 
> > > > Â- add two 'generic' DOM_{ADD,REM} events. They're
> > > > ÂÂÂmade part of the TRC_DOM0 tracing class, as Dom0
> > > > ÂÂÂis, usually, from where domains are created and
> > > > ÂÂÂdestroyed.
> > > > 
> > > > Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> > > 
> > > Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>
> > > 
> > > Since this changes domain.c, I guess this would need an ack from
> > > "The
> > > Rest" -- probably either from Jan or Ian, since they're somewhat
> > > familiar with this code...?
> > > 
> > Ping (Ian, Jan)?
> 
> This has even passed the push gate already.
> 
Ah, good to hear that! :-)

I see it now:

commit 7d42c7615045e75b9231a309ec452d7543099773
Author: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
Date:ÂÂÂThu Feb 18 15:03:34 2016 +0100
....
....
Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

So, it looks like you've acked it and, I presume, checked it in.

My bad not double checking if it was in... I just didn't think that
could be the case, as I thought an answer to George's suggestion of an
Ack would hit the mailing list, if only for the sake of
archives/history (unless I've also missed such email! :-P).

In any case, sorry for the noise.

Thanks and Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.