Re: [Xen-devel] [PATCH 8/9] xl: Improve return and exit codes main_button_press(), main_trigger(), main_remus() and related functions.

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Wed, 2016-02-24 at 18:23 +0530, Harmandeep Kaur wrote:
> Signed-off-by: Harmandeep Kaur <write.harmandeep@xxxxxxxxx>
>
About the subject lines: try to make them more abstract. It does not
scale to list all the changed functions! :-)

So, in this case, something like (just out of the top of my head!)
"debugging, special keys and triggering related functions".

And main_remus() does not really belong here, while main_sysrq(),
main_trigger(), and probably even main_debug_keys() and main_dmesg()
can well do.

> ---
>  tools/libxl/xl_cmdimpl.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index f7f7d7f..9e0a467 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -374,7 +374,7 @@ static void xvasprintf(char **strp, const char
> *fmt, va_list ap)
>      int r = vasprintf(strp, fmt, ap);
>      if (r == -1) {
>          perror("asprintf failed");
> -        exit(-ERROR_FAIL);
> +        exit(EXIT_FAILURE);
>
xvasprintf() doesn't fit here either.

Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel