Re: [Xen-devel] staging: libxl compile error in libxl__domain_save

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 27/02/2016 08:14, Olaf Hering wrote:
> Current staging fails to compile:
>
> [  276s] libxl_dom_save.c: In function 'libxl__domain_save':
> [  276s] libxl_dom_save.c:328:9: error: 'rc' may be used uninitialized in 
> this function
>
> It was introduced between abf8824fe530bcf060c757596f68663c87546a6a and
> 3dd926a25d866364ce6d46c21f9ac05a82fa7ffb. Would travis catch such
> errors?

-Wmaybe-uninitalised is quite distro-specific as to whether it is
enabled by default or not.

Travis being ubuntu-based, it appears not. 
https://travis-ci.org/xen-project/xen/builds/112092866

I am tempted to suggest explicitly enabling it.  I have lost count of
how many times I have found the build legitimately broken on CentOS, due
to their default of -Wmaybe-initialised.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel