[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] staging: libxl compile error in libxl__domain_save



On Sun, Feb 28, 2016 at 02:10:16PM +0000, Andrew Cooper wrote:
> On 28/02/16 02:01, Doug Goldstein wrote:
> > On 2/27/16 2:14 AM, Olaf Hering wrote:
> >> Current staging fails to compile:
> >>
> >> [  276s] libxl_dom_save.c: In function 'libxl__domain_save':
> >> [  276s] libxl_dom_save.c:328:9: error: 'rc' may be used uninitialized in 
> >> this function
> >>
> >> It was introduced between abf8824fe530bcf060c757596f68663c87546a6a and
> >> 3dd926a25d866364ce6d46c21f9ac05a82fa7ffb. Would travis catch such
> >> errors?
> >>
> > Travis currently wouldn't catch this because I've got tools disabled
> > from building.
> 
> Oops yes - of course.
> 
> >  The reason for this is because the configure script fails
> > to properly find Python due to problems with how AC_CHECK_LIB is called.
> > Down the road this doesn't matter because we never use that output from
> > the configure script and instead utilize setuptools to build the
> > extensions which do linking correctly.
> >
> > The relevant patch is here and still waiting for an ACK:
> >
> > http://lists.xen.org/archives/html/xen-devel/2016-02/msg02715.html
> >
> > Once that gets merged and I can enable tools building on Travis then yes
> > it would catch it.
> 
> There is still the HVMLoader errno issue, and the Clang (__align8__
> uint64_t) issue.
> 
> What about SeaBIOS?  Is that fixed in the 1.9.1 tag, or are there
> further issues luring?

1.9.1 tag is in, and so is the change in the Config.mk to use that.

> 
> ~Andrew
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.