Re: [Xen-devel] [PATCH v5 6/6] docs: Add descriptions of TSC scaling in xl.cfg and tscmode.txt

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: Friday, February 26, 2016 4:01 PM
> 
> >>> On 26.02.16 at 05:37, <kevin.tian@xxxxxxxxx> wrote:
> >>  From: Zhang, Haozhong
> >> Sent: Tuesday, February 23, 2016 10:05 AM
> >>
> >> Signed-off-by: Haozhong Zhang <haozhong.zhang@xxxxxxxxx>
> >
> > Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>, except:
> >
> >> +
> >> +Hardware TSC Scaling
> >> +
> >> +Intel VMX TSC scaling and AMD SVM TSC ratio allow the guest TSC read
> >> +by guest rdtsc/p increasing in a different frequency than the host
> >> +TSC frequency.
> >> +
> >> +If a HVM container in default TSC mode (tsc_mode=0) or PVRDTSCP mode
> >
> > 'HVM container' means something different. We usually use "HVM domain"
> > as you may see in other places in this doc.
> 
> But I think this is specifically meant to refer to both HVM and PVH
> domains.
> 

First, I have a feeling that many people today refer to containers
running within a VM as 'VM container', which is a bit confusing to
'HVM container' purpose here. Couldn't we use 'HVM domains'
to cover both HVM and PVH (which is PV-HVM)? Curious whether
there is formal definition of those terminologies...

Second, even when 'HVM container' can be used as you explained,
it's inconsistent with other places in same doc, where only 'HVM
domain' is used. I'd think consistency is more important in this
patch series, and then if 'HVM container' is really preferred which
should be a separate patch to update all related docs.

Thanks
Kevin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel