Re: [Xen-devel] [BUG] documentation of xs.transaction_end is inconsistent with the implementation

[Sergei Lebedev <sergei.a.lebedev@xxxxxxxxx>]

The same is true of ``xs.mkdir``.

#define xspy_mkdir_doc "\n"                                     \
        "Make a directory.\n"                                   \
        " path [string]: path to directory to create.\n"        \
        "\n"                                                    \
        "Returns None on success.\n"                            \
        "Raises xen.lowlevel.xs.Error on error.\n"                      \
        "\n"

Sergei

> On 29 Feb 2016, at 14:55, Sergei Lebedev <sergei.a.lebedev@xxxxxxxxx> wrote:
> 
> Hi list,
> 
> The documentation of ``xs.transaction_end`` (from xen.lowlevel xs) doesn’t 
> mention that the method accepts transaction handle 
> 
> #define xspy_transaction_end_doc "\n"                                 \
>       "End the current transaction.\n"                                \
>       "Attempts to commit the transaction unless abort is true.\n"    \
>       " abort [int]: abort flag (default 0).\n"                       \
>       "\n"                                                            \
>       "Returns True on success, False if you need to try again.\n"    \
>       "Raises xen.lowlevel.xs.Error on error.\n"                              
> \
>       "\n"
> 
> while the implementation clearly expects it [*]
> 
>    int abort = 0;
>    char *thstr;
> 
>    if (!PyArg_ParseTupleAndKeywords(args, kwds, arg_spec, kwd_spec,
>                                     &thstr, &abort))
>        return NULL;
> 
> 
> Regards,
> Sergei
> 
> [*]: 
> http://xenbits.xen.org/gitweb/?p=xen.git;a=blob_plain;f=tools/python/xen/lowlevel/xs/xs.c;hb=HEAD


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel