Re: [Xen-devel] Prototype Code Review Dashboards (input required)

[Lars Kurth <lars.kurth.xen@xxxxxxxxx>]

> On 4 Mar 2016, at 08:42, Jan Beulich <JBeulich@xxxxxxxx> wrote:
> 
>>>> On 03.03.16 at 19:55, <lars.kurth.xen@xxxxxxxxx> wrote:
>>> On 2 Mar 2016, at 22:45, Daniel Izquierdo <dizquierdo@xxxxxxxxxxxx> wrote:
>>> On 01/03/16 18:04, Lars Kurth wrote:
>>>> Q2: What is the scope? Do the number count
>>>> - the # files someone reviewed
>>>> - the # patches someone reviewed
>>>> - the # series someone reviewed
>>> 
>>> The number counts the number of reviews accomplished by a developer or by a 
>> domain. A review is accomplished when the flag 'reviewed-by' is detected in 
>> a 
>> email replying a patch.
>>> 
>>> If a developer reviews several patches or several versions of the same 
>> patch, each of those is counted as a different review.
>> 
>> So this is basically the number of reviewed by flags aggregated per 
>> developer. 
>> 
>>>> If a reviewer is solely defined by the reviewed-by tags, the data does not 
>>>> provide a correct picture.
>>> This is how this works so far.
>>> 
>>>> It may be better to use the following definition (although, others may 
>>>> disagree)
>>>> A reviewer is someone who did one of the following for a patch or series:
>>>> - Added a reviewed-by flag
>>>> - Added an acked-by flag (maintainers tend to use acked-by)
>>>> - Made a comment, but is NOT the author
>>> 
>>> We can update that definition. Do we want to have extra discussion with 
>>> this respect?
>> 
>> I think that would be more correct. In particular, as we still will be able 
>> @Jan, what is your view? This use-case was primarily created because of 


> Two of your reply sentences seem to be missing their tails, so it's
> really hard for me to tell my view, as it's not really clear what
> you're asking for.

Apologies

I think that would be more correct. In particular, as we still will be able to 
get the reviewed-by and acked-by flags from the tools we already have (and they 
are also covered in graphs). They represent an outcome, but not really the 
effort that is spent on reviews. And the comments as used in the other panels, 
do not differentiate between people reviewing and responding to reviews.

@Jan, the use-case to measure real review contributions was primarily added on 
your request. Do you think the proposed definition above, is good enough?

Lars
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel