Re: [Xen-devel] [PATCH v11 25/27] setup and control colo proxy on primary side

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

> +static void colo_proxy_async_call(libxl__egc *egc,
> +                                  libxl__colo_save_state *css,
> +                                  void func(libxl__colo_save_state *),
> +                                  libxl__ev_child_callback callback)
> +{

This is a straight clone-and-hack of drbd_async_call.  Please make a
common function, or something.

> +static void colo_proxy_async_wait_for_checkpoint(libxl__colo_save_state *css)
> +{
> +    int req;
> +
> +    req = colo_proxy_checkpoint(&css->cps, 5000000);

What is this magic number ?  This seems quite odd...

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel