[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v11 25/27] setup and control colo proxy on primary side
- To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
- From: Changlong Xie <xiecl.fnst@xxxxxxxxxxxxxx>
- Date: Tue, 22 Mar 2016 14:01:31 +0800
- Cc: Lars Kurth <lars.kurth@xxxxxxxxxx>, Li Zhijian <lizhijian@xxxxxxxxxxxxxx>, Wei Liu <wei.liu2@xxxxxxxxxx>, Ian Campbell <ian.campbell@xxxxxxxxxx>, Wen Congyang <wency@xxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jiang Yunhong <yunhong.jiang@xxxxxxxxx>, Dong Eddie <eddie.dong@xxxxxxxxx>, xen devel <xen-devel@xxxxxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Gui Jianfeng <guijianfeng@xxxxxxxxxxxxxx>, Shriram Rajagopalan <rshriram@xxxxxxxxx>, Yang Hongyang <hongyang.yang@xxxxxxxxxxxx>
- Delivery-date: Tue, 22 Mar 2016 05:59:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On 03/05/2016 02:05 AM, Ian Jackson wrote:
+static void colo_proxy_async_call(libxl__egc *egc,
+ libxl__colo_save_state *css,
+ void func(libxl__colo_save_state *),
+ libxl__ev_child_callback callback)
+{
This is a straight clone-and-hack of drbd_async_call. Please make a
common function, or something.
Ok
+static void colo_proxy_async_wait_for_checkpoint(libxl__colo_save_state *css)
+{
+ int req;
+
+ req = colo_proxy_checkpoint(&css->cps, 5000000);
What is this magic number ? This seems quite odd...
It's an empirical timeout value(5s) for waiting a checkpoint.
Thanks
-Xie
Thanks,
Ian.
.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
