Re: [Xen-devel] [PATCH 1/2] xsm: move the XSM_MAGIC value to Kconfig

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.03.16 at 19:42, <cardoe@xxxxxxxxxx> wrote:
> Let Kconfig set the XSM_MAGIC value for us.

What's the benefit of doing this at the Kconfig layer?

> --- a/xen/common/Kconfig
> +++ b/xen/common/Kconfig
> @@ -113,6 +113,14 @@ config XSM
>  
>         If unsure, say N.
>  
> +# XSM magic for policy detection
> +config XSM_MAGIC
> +    hex
> +    default 0xf97cff8c if FLASK
> +    default 0 if !FLASK

This second "if" is pointless.

Also note the broken indentation (using spaces instead of a tab).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel