Re: [Xen-devel] [PATCH 2/2] xsm: move FLASK_AVC_STATS to Kconfig

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.03.16 at 19:42, <cardoe@xxxxxxxxxx> wrote:
> Have Kconfig set CONFIG_FLASK_AVC_STATS and prefix all uses with CONFIG_
> to use the Kconfig variable.

Same question here: What's the benefit of doing it this way?

> --- a/xen/common/Kconfig
> +++ b/xen/common/Kconfig
> @@ -23,6 +23,12 @@ config FLASK
>  
>         If unsure, say N.
>  
> +config FLASK_AVC_STATS
> +    def_bool y if FLASK
> +    depends on FLASK

With this "depends" the "if FLASK" is pointless.

Also (again) - indentation.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel