[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] tools/foreign: Avoid using alignment directives when not appropriate

>>> On 07.03.16 at 19:28, <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/tools/include/xen-foreign/Makefile
> +++ b/tools/include/xen-foreign/Makefile
> @@ -35,6 +35,8 @@ x86_32.h: mkheader.py structs.py 
> $(ROOT)/arch-x86/xen-x86_32.h $(ROOT)/arch-x86/
>  x86_64.h: mkheader.py structs.py $(ROOT)/arch-x86/xen-x86_64.h 
> $(ROOT)/arch-x86/xen.h $(ROOT)/xen.h
>       $(PYTHON) $< $* $@ $(filter %.h,$^)
> +     #Avoid mixing an alignment directive with a uint64_t cast or sizeof 
> expression
> +     sed 's/(__align8__ uint64_t)/(uint64_t)/g' -i $@

A two step rule like this should make use of a temporary file, to
avoid breakage when the build process gets interrupted between
the two steps.

And then - is it perhaps worth to generalize the pattern in one or
more of a couple of possible ways? Considering int64_t uses
would perhaps be the most relevant one (even if not needed
right away). But of course this could get as generic as

s/(__align[0-9]*__ \([a-z0-9_]*\))/(\1)/g

without - afaict (based on your commit description) - breaking


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.