Re: [Xen-devel] [PATCH 2/2] xsm: move FLASK_AVC_STATS to Kconfig

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.03.16 at 17:22, <dgdegra@xxxxxxxxxxxxx> wrote:
> On 03/08/2016 04:46 AM, Jan Beulich wrote:
>>>>> On 07.03.16 at 19:42, <cardoe@xxxxxxxxxx> wrote:
>>> Have Kconfig set CONFIG_FLASK_AVC_STATS and prefix all uses with CONFIG_
>>> to use the Kconfig variable.
>>
>> Same question here: What's the benefit of doing it this way?
> 
> This removes the stats tracking, which might (I have not tested) speed up
> the security server by avoiding the __get_cpu_var call and increment.

No, I don not think the patch removes anything. The Kconfig option
doesn't have a prompt. But anyway, ...

> The
> corresponding SELinux knob is a Kconfig option in Linux.
> 
> Acked-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>

... if you're fine with it, we'll put it in (once the mechanical issues
got addressed).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel