Re: [Xen-devel] [PATCH v4 13/34] libxc: Implementation of XEN_XSPLICE_op in libxc

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Wed, Mar 16, 2016 at 06:12:02PM +0000, Wei Liu wrote:
> On Tue, Mar 15, 2016 at 01:56:35PM -0400, Konrad Rzeszutek Wilk wrote:
> > The underlaying toolstack code to do the basic
> > operations when using the XEN_XSPLICE_op syscalls:
> >  - upload the payload,
> >  - get status of an payload,
> >  - list all the payloads,
> >  - apply, check, replace, and revert the payload.
> > 
> > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> > Signed-off-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
> > 
> > ---
> > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> > Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> > 
> > v2: Actually set zero for the _pad entries.
> > v3: Split status into state and error code.
> >     Add REPLACE action.
> > v4: Use timeout and utilize pads.
> > v5: Update per Wei's review.
> > v6: Update per Wei's review.
> > v7: Extra space slipped in, remove it
> 
> Huh, the title says  v4 but here it is v7.
> 
> I believe issues I mentioned in previous iterations are fixed.

Yes. Thanks.
> 
> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> 
> Only one nitpick below.
> 
> > +/*
> > + * The operations are asynchronous and the hypervisor may take a while
> > + * to complete them. The `timeout` offers an option to expire the
> > + * operation if it could not be completed within the specified time.
> > + * Value of 0 means let hypervisor decide the best timeout.
> > + */
> 
> Might be useful to specify the unit of timeout (ms?).

Done! Thanks!
> 
> 
> Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel