Re: [Xen-devel] [PATCH v3 21/28] xen+tools: Export maximum host and guest cpu featuresets via SYSCTL

[David Scott <dave@xxxxxxxxxx>]

> On 16 Mar 2016, at 18:23, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> 
> On Tue, Mar 15, 2016 at 03:35:17PM +0000, Andrew Cooper wrote:
>> And provide stubs for toolstack use.
>> 
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> ---
>> CC: Jan Beulich <JBeulich@xxxxxxxx>
>> CC: Tim Deegan <tim@xxxxxxx>
>> CC: Wei Liu <wei.liu2@xxxxxxxxxx>
>> CC: David Scott <dave@xxxxxxxxxx>
>> CC: Rob Hoes <Rob.Hoes@xxxxxxxxxx>
>> 
>> v3:
>> * Provide libxc implementation for XEN_SYSCTL_get_cpu_levelling_caps as well.
>> v2:
>> * Rebased to use libxencall
>> * Improve hypercall documentation
>> ---
>> tools/libxc/include/xenctrl.h       |  4 +++
>> tools/libxc/xc_cpuid_x86.c          | 41 +++++++++++++++++++++++++++++
> 
> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> 
>> tools/ocaml/libs/xc/xenctrl.ml      |  3 +++
>> tools/ocaml/libs/xc/xenctrl.mli     |  4 +++
>> tools/ocaml/libs/xc/xenctrl_stubs.c | 35 +++++++++++++++++++++++++
> 
> The ocaml wrappers also look sensible. But admittedly my ocaml skill is
> limited so I will defer those to Dave or Rob.

The OCaml stubs look safe to me

Acked-by: David Scott <dave@xxxxxxxxxx>

Cheers,
Dave
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel